Skip to content

fix(parse): honor custom style lifts#458

Draft
quinnj wants to merge 1 commit into
masterfrom
codex/fix-custom-style-lift
Draft

fix(parse): honor custom style lifts#458
quinnj wants to merge 1 commit into
masterfrom
codex/fix-custom-style-lift

Conversation

@quinnj
Copy link
Copy Markdown
Member

@quinnj quinnj commented May 14, 2026

Summary

  • normalize custom style lift return values so plain values work as expected
  • call custom lazy object/array lifts before default materialization
  • add regression tests for custom Date parse styles from issue Multiple Styles for same Struct not working #434

Testing

  • julia --project=. -e 'using Pkg; Pkg.test(; coverage=false)'

Fixes #434

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.21%. Comparing base (1efd912) to head (99f8b78).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/parse.jl 80.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
- Coverage   90.25%   90.21%   -0.04%     
==========================================
  Files           7        7              
  Lines        1395     1411      +16     
==========================================
+ Hits         1259     1273      +14     
- Misses        136      138       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@quinnj quinnj marked this pull request as draft May 14, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple Styles for same Struct not working

1 participant